|
|||||||||
PREV CLASS NEXT CLASS | FRAMES NO FRAMES | ||||||||
SUMMARY: NESTED | FIELD | CONSTR | METHOD | DETAIL: FIELD | CONSTR | METHOD |
java.lang.Objectnet.sourceforge.pmd.CommonAbstractRule
net.sourceforge.pmd.AbstractJavaRule
net.sourceforge.pmd.AbstractRule
net.sourceforge.pmd.rules.AbstractPoorMethodCall
public abstract class AbstractPoorMethodCall
Detects and flags the occurrences of specific method calls against an instance of a designated class. I.e. String.indexOf. The goal is to be able to suggest more efficient/modern ways of implementing the same function. Concrete subclasses are expected to provide the name of the target class and an array of method names that we are looking for. We then pass judgement on any literal arguments we find in the subclass as well.
Field Summary |
---|
Fields inherited from interface net.sourceforge.pmd.Rule |
---|
LOWEST_PRIORITY, PRIORITIES |
Constructor Summary | |
---|---|
AbstractPoorMethodCall()
|
Method Summary | |
---|---|
static boolean |
isSingleCharAsString(java.lang.String value)
Returns whether the value argument is a single character string. |
protected abstract boolean |
isViolationArgument(int argIndex,
java.lang.String arg)
Returns whether the string argument at the stated position being sent to the method is ok or not. |
protected abstract java.lang.String[] |
methodNames()
Return the names of all the methods we are scanning for, no brackets or argument types. |
protected abstract java.lang.String |
targetTypename()
The name of the type the method will be invoked against. |
java.lang.Object |
visit(ASTVariableDeclaratorId node,
java.lang.Object data)
Method visit. |
Methods inherited from class net.sourceforge.pmd.AbstractJavaRule |
---|
addViolation, addViolation, addViolation, addViolationWithMessage, apply, getDeclaringType, importsPackage, isQualifiedName, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visitAll |
Methods inherited from class java.lang.Object |
---|
clone, finalize, getClass, notify, notifyAll, toString, wait, wait, wait |
Constructor Detail |
---|
public AbstractPoorMethodCall()
Method Detail |
---|
protected abstract java.lang.String targetTypename()
protected abstract java.lang.String[] methodNames()
protected abstract boolean isViolationArgument(int argIndex, java.lang.String arg)
argIndex
- intarg
- String
public static boolean isSingleCharAsString(java.lang.String value)
value
- String
public java.lang.Object visit(ASTVariableDeclaratorId node, java.lang.Object data)
visit
in interface JavaParserVisitor
visit
in class AbstractJavaRule
node
- ASTVariableDeclaratorIddata
- Object
JavaParserVisitor.visit(ASTVariableDeclaratorId, Object)
|
|||||||||
PREV CLASS NEXT CLASS | FRAMES NO FRAMES | ||||||||
SUMMARY: NESTED | FIELD | CONSTR | METHOD | DETAIL: FIELD | CONSTR | METHOD |