From 9c398becbeb5004fc747c2ab3a51e0d2627607d2 Mon Sep 17 00:00:00 2001 Message-Id: <9c398becbeb5004fc747c2ab3a51e0d2627607d2.1379425497.git.minovotn@redhat.com> In-Reply-To: References: From: Paolo Bonzini Date: Fri, 6 Sep 2013 18:12:39 +0200 Subject: [PATCH 19/25] block: return get_block_status data and flags for formats Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi (cherry picked from commit 4bc74be997a72922170f4f272fd5e8074a3ecc27) Signed-off-by: Michal Novotny --- block/cow.c | 8 +++++++- block/qcow.c | 9 ++++++++- block/qcow2.c | 13 ++++++++++--- block/qed.c | 35 ++++++++++++++++++++++++++++------- block/vdi.c | 11 ++++++++++- block/vmdk.c | 19 ++++++++++++++++++- block/vvfat.c | 11 ++++++----- 7 files changed, 87 insertions(+), 19 deletions(-) diff --git a/block/cow.c b/block/cow.c index 39032cb..8a43161 100644 --- a/block/cow.c +++ b/block/cow.c @@ -191,7 +191,13 @@ static int coroutine_fn cow_co_is_allocated(BlockDriverState *bs, static int64_t coroutine_fn cow_co_get_block_status(BlockDriverState *bs, int64_t sector_num, int nb_sectors, int *num_same) { - return cow_co_is_allocated(bs, sector_num, nb_sectors, num_same); + BDRVCowState *s = bs->opaque; + int ret = cow_co_is_allocated(bs, sector_num, nb_sectors, num_same); + int64_t offset = s->cow_sectors_offset + (sector_num << BDRV_SECTOR_BITS); + if (ret < 0) { + return ret; + } + return (ret ? BDRV_BLOCK_DATA : 0) | offset | BDRV_BLOCK_OFFSET_VALID; } static int cow_update_bitmap(BlockDriverState *bs, int64_t sector_num, diff --git a/block/qcow.c b/block/qcow.c index 6df355c..a9f0505 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -401,7 +401,14 @@ static int64_t coroutine_fn qcow_co_get_block_status(BlockDriverState *bs, if (n > nb_sectors) n = nb_sectors; *pnum = n; - return (cluster_offset != 0); + if (!cluster_offset) { + return 0; + } + if ((cluster_offset & QCOW_OFLAG_COMPRESSED) || s->crypt_method) { + return BDRV_BLOCK_DATA; + } + cluster_offset |= (index_in_cluster << BDRV_SECTOR_BITS); + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | cluster_offset; } static int decompress_buffer(uint8_t *out_buf, int out_buf_size, diff --git a/block/qcow2.c b/block/qcow2.c index 8a185c5..dd01506 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -382,7 +382,7 @@ static int64_t coroutine_fn qcow2_co_get_block_status(BlockDriverState *bs, { BDRVQcowState *s = bs->opaque; uint64_t cluster_offset; - int ret; + int index_in_cluster, ret; *pnum = nb_sectors; qemu_co_mutex_lock(&s->lock); @@ -391,8 +391,15 @@ static int64_t coroutine_fn qcow2_co_get_block_status(BlockDriverState *bs, if (ret < 0) { return ret; } - - return (cluster_offset != 0); + if (!cluster_offset) { + return 0; + } + if ((cluster_offset & QCOW_OFLAG_COMPRESSED) || s->crypt_method) { + return BDRV_BLOCK_DATA; + } + index_in_cluster = sector_num & (s->cluster_sectors - 1); + cluster_offset |= (index_in_cluster << BDRV_SECTOR_BITS); + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | cluster_offset; } /* handle reading after the end of the backing file */ diff --git a/block/qed.c b/block/qed.c index 2ca2bfe..454600a 100644 --- a/block/qed.c +++ b/block/qed.c @@ -655,16 +655,36 @@ static int bdrv_qed_create(const char *filename, QEMUOptionParameter *options) } typedef struct { + BlockDriverState *bs; Coroutine *co; - int is_allocated; + uint64_t pos; + int64_t status; int *pnum; } QEDIsAllocatedCB; static void qed_is_allocated_cb(void *opaque, int ret, uint64_t offset, size_t len) { QEDIsAllocatedCB *cb = opaque; + BDRVQEDState *s = cb->bs->opaque; *cb->pnum = len / BDRV_SECTOR_SIZE; - cb->is_allocated = (ret == QED_CLUSTER_FOUND || ret == QED_CLUSTER_ZERO); + switch (ret) { + case QED_CLUSTER_FOUND: + offset |= qed_offset_into_cluster(s, cb->pos); + cb->status = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | offset; + break; + case QED_CLUSTER_ZERO: + cb->status = BDRV_BLOCK_ZERO; + break; + case QED_CLUSTER_L2: + case QED_CLUSTER_L1: + cb->status = 0; + break; + default: + assert(ret < 0); + cb->status = ret; + break; + } + if (cb->co) { qemu_coroutine_enter(cb->co, NULL); } @@ -675,25 +695,26 @@ static int64_t coroutine_fn bdrv_qed_co_get_block_status(BlockDriverState *bs, int nb_sectors, int *pnum) { BDRVQEDState *s = bs->opaque; - uint64_t pos = (uint64_t)sector_num * BDRV_SECTOR_SIZE; size_t len = (size_t)nb_sectors * BDRV_SECTOR_SIZE; QEDIsAllocatedCB cb = { - .is_allocated = -1, + .bs = bs, + .pos = (uint64_t)sector_num * BDRV_SECTOR_SIZE, + .status = BDRV_BLOCK_OFFSET_MASK, .pnum = pnum, }; QEDRequest request = { .l2_table = NULL }; - qed_find_cluster(s, &request, pos, len, qed_is_allocated_cb, &cb); + qed_find_cluster(s, &request, cb.pos, len, qed_is_allocated_cb, &cb); /* Now sleep if the callback wasn't invoked immediately */ - while (cb.is_allocated == -1) { + while (cb.status == BDRV_BLOCK_OFFSET_MASK) { cb.co = qemu_coroutine_self(); qemu_coroutine_yield(); } qed_unref_l2_cache_entry(request.l2_table); - return cb.is_allocated; + return cb.status; } static int bdrv_qed_make_empty(BlockDriverState *bs) diff --git a/block/vdi.c b/block/vdi.c index ada5baf..eaa4de1 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -463,12 +463,21 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriverState *bs, size_t sector_in_block = sector_num % s->block_sectors; int n_sectors = s->block_sectors - sector_in_block; uint32_t bmap_entry = le32_to_cpu(s->bmap[bmap_index]); + uint64_t offset; + logout("%p, %" PRId64 ", %d, %p\n", bs, sector_num, nb_sectors, pnum); if (n_sectors > nb_sectors) { n_sectors = nb_sectors; } *pnum = n_sectors; - return bmap_entry != VDI_UNALLOCATED; + if (bmap_entry == VDI_UNALLOCATED) { + return 0; + } + + offset = s->header.offset_data + + (uint64_t)bmap_entry * s->block_size + + sector_in_block * SECTOR_SIZE; + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | offset; } static void vdi_aio_cancel(BlockDriverAIOCB *blockacb) diff --git a/block/vmdk.c b/block/vmdk.c index 0f4b09e..bf21515 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1050,7 +1050,24 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, sector_num * 512, 0, &offset); qemu_co_mutex_unlock(&s->lock); - ret = (ret == VMDK_OK || ret == VMDK_ZEROED); + switch (ret) { + case VMDK_ERROR: + ret = -EIO; + break; + case VMDK_UNALLOC: + ret = 0; + break; + case VMDK_ZEROED: + ret = BDRV_BLOCK_ZERO; + break; + case VMDK_OK: + ret = BDRV_BLOCK_DATA; + if (extent->file == bs->file) { + ret |= BDRV_BLOCK_OFFSET_VALID | offset; + } + + break; + } index_in_cluster = sector_num % extent->cluster_sectors; n = extent->cluster_sectors - index_in_cluster; diff --git a/block/vvfat.c b/block/vvfat.c index 4e9fbfc..d0e6f82 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2773,11 +2773,12 @@ static int64_t coroutine_fn vvfat_co_get_block_status(BlockDriverState *bs, { BDRVVVFATState* s = bs->opaque; *n = s->sector_count - sector_num; - if (*n > nb_sectors) - *n = nb_sectors; - else if (*n < 0) - return 0; - return 1; + if (*n > nb_sectors) { + *n = nb_sectors; + } else if (*n < 0) { + return 0; + } + return BDRV_BLOCK_DATA; } static int write_target_commit(BlockDriverState *bs, int64_t sector_num, -- 1.7.11.7