From d43b3f0fa49ffe1276d692ec4cff8db75da3908f Mon Sep 17 00:00:00 2001 From: Max Reitz Date: Wed, 16 Sep 2015 16:23:07 +0200 Subject: [PATCH 2/2] iotests: Add test for checking large image files Message-id: <1442420587-13545-3-git-send-email-mreitz@redhat.com> Patchwork-id: 67790 O-Subject: [RHEV-7.2 qemu-kvm-rhev PATCH 2/2] iotests: Add test for checking large image files Bugzilla: 1260365 RH-Acked-by: Eric Blake RH-Acked-by: Laurent Vivier RH-Acked-by: Kevin Wolf Add a test for checking a qcow2 file with a multiple of 2^32 clusters. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf (cherry picked from commit 097b500c2dff7addfcd5f4c8a111f6bfd0cb3977) Signed-off-by: Miroslav Rezanina Conflicts: tests/qemu-iotests/group Signed-off-by: Max Reitz --- tests/qemu-iotests/138 | 73 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/138.out | 9 ++++++ tests/qemu-iotests/group | 1 + 3 files changed, 83 insertions(+) create mode 100755 tests/qemu-iotests/138 create mode 100644 tests/qemu-iotests/138.out diff --git a/tests/qemu-iotests/138 b/tests/qemu-iotests/138 new file mode 100755 index 0000000..a5c3464 --- /dev/null +++ b/tests/qemu-iotests/138 @@ -0,0 +1,73 @@ +#!/bin/bash +# +# General test case for qcow2's image check +# +# Copyright (C) 2015 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +# creator +owner=mreitz@redhat.com + +seq="$(basename $0)" +echo "QA output created by $seq" + +here="$PWD" +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# This tests qocw2-specific low-level functionality +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux + +echo +echo '=== Check on an image with a multiple of 2^32 clusters ===' +echo + +IMGOPTS=$(_optstr_add "$IMGOPTS" "cluster_size=512") \ + _make_test_img 512 + +# Allocate L2 table +$QEMU_IO -c 'write 0 512' "$TEST_IMG" | _filter_qemu_io + +# Put the data cluster at a multiple of 2 TB, resulting in the image apparently +# having a multiple of 2^32 clusters +# (To be more specific: It is at 32 PB) +poke_file "$TEST_IMG" 2048 "\x80\x80\x00\x00\x00\x00\x00\x00" + +# An offset of 32 PB results in qemu-img check having to allocate an in-memory +# refcount table of 128 TB (16 bit refcounts, 512 byte clusters). +# This should be generally too much for any system and thus fail. +# What this test is checking is that the qcow2 driver actually tries to allocate +# such a large amount of memory (and is consequently aborting) instead of having +# truncated the cluster count somewhere (which would result in much less memory +# being allocated and then a segfault occurring). +_check_test_img + +# success, all done +echo "*** done" +rm -f $seq.full +status=0 diff --git a/tests/qemu-iotests/138.out b/tests/qemu-iotests/138.out new file mode 100644 index 0000000..3fe911f --- /dev/null +++ b/tests/qemu-iotests/138.out @@ -0,0 +1,9 @@ +QA output created by 138 + +=== Check on an image with a multiple of 2^32 clusters === + +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=512 +wrote 512/512 bytes at offset 0 +512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +qemu-img: Check failed: Cannot allocate memory +*** done diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 497b583..f8e3b02 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -126,3 +126,4 @@ 128 rw auto quick 130 rw auto quick 132 rw auto quick +138 rw auto quick -- 1.8.3.1